Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resize to transforms.py #22634

Closed
wants to merge 4 commits into from
Closed

Add resize to transforms.py #22634

wants to merge 4 commits into from

Conversation

alec-kr
Copy link
Contributor

@alec-kr alec-kr commented Aug 27, 2023

This PR adds the resize function to the existing codebase in transforms.py.

Related Issue

Closes #22633

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Aug 27, 2023
@AlexandraPosta
Copy link
Contributor

Hello @alec-kr, please solve your merge conflicts and I will review it right after.

@alec-kr
Copy link
Contributor Author

alec-kr commented Aug 29, 2023

@AlexandraPosta Merge conflicts have now been resolved.

@AlexandraPosta
Copy link
Contributor

Hello @alec-kr! Thank you for that.

I have just noticed that you have not reference the issue properly. Please check our documentation and change the comment that you left here. Currently, in the task list, your function is not referenced as open, so a different contributor can take it over.

In terms of the function implementation, by looking at the raw log, you get this error: AttributeError: module 'ivy.functional.backends.torch' has no attribute 'resize'. Normally, the process needed to change the size of the given is called interpolation. At ivy, we have a backend function dedicated for interpolation that I would suggest you to use.

@AlexandraPosta
Copy link
Contributor

AlexandraPosta commented Sep 28, 2023

Hello @alec-kr, just checking whether you are still working on the PR. ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resize
3 participants